Properly flush nested setState callbacks (-6 B) #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would synchronously flush nested renderCallbacks. This behavior meant that nested setState calls would flush before there state was properly applied in diff, meaning DOM, props, etc. wouldn't have been updated for that setState call when the callback was run (though the state would be correct due to a shortcut we took). This PR fixes this behavior by only invoking the renderCallbacks for the current setState call synchronously. Nested setState callbacks are queued and executed when those setState cals are applied.
andrewiggins
changed the title
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would synchronously flush nested renderCallbacks (i.e. setState and forceUpdate callbacks). This behavior meant that nested setState calls would flush before the state was properly applied in diff, meaning DOM, props, etc. wouldn't have been updated for that setState call when the callback was run (though the state would be correct due to a shortcut we took).
This PR fixes this behavior by only invoking the renderCallbacks for the current setState call synchronously. Nested setState callbacks are queued and executed when those setState calls are applied.
Also includes a small change to make
setStateandforceUpdatea little more similar which I assume helps gzip.