Fix Suspense Hydration #2291
Draft
Fix Suspense Hydration #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eekbh/suspense-hydration
…actjs/preact into prateekbh/suspense-hydration
…eekbh/suspense-hydration
…actjs/preact into prateekbh/suspense-hydration
developit
requested review from
andrewiggins,
marvinhagemeister,
prateekbh and
JoviDeCroock
|
Size Change: +28 B (0%) Total Size: 38.4 kB
ℹ️ View Unchanged
|
prateekbh
reviewed
Jan 30, 2020
src/diff/index.js
Outdated
| // We can use this information if we return here to render later on. | ||
| oldVNode._hydrateDom = newVNode._dom = oldDom; | ||
| } | ||
| newVNode._dom = oldDom; // is this needed? |
There was a problem hiding this comment.
The Suspense tests pass if we still keep isHydrating check
There was a problem hiding this comment.
IIRC newVNode._dom = oldDom; is needed because the diff remove the DOM otherwise it removes the existing DOM in next render.
There was a problem hiding this comment.
I'll try to get this fixed.
Comment on lines
+92
to
+93
| const wasHydrating = vnode && vnode._hydrating === true; | ||
| if (!wasHydrating && !c._suspensions++) { |
There was a problem hiding this comment.
Suggested change
| const wasHydrating = vnode && vnode._hydrating === true; | |
| if (!wasHydrating && !c._suspensions++) { | |
| if (!(vnode && vnode._hydrating === true) && !c._suspensions++) { |
developit
changed the base branch from
prateekbh/suspense-hydration
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of annotating the VNode at a suspend point (a component that threw during render) with
_hydrateDom, annotate the VNode at the Suspense boundary (the component that implementedcomponentDidCatch()). When re-rendering a component, if its owner vnode has a boolean._hydratingproperty value, that means we should attempt to resume from the VNode's current._domreference.You can try this PR by checking out the suspense-hydration-testing branch of preactjs/cli-demo. Clone, then run
npm i && npm link ../preact && npm run build && http-server -s -p 8080 buildNote: looking at this, I believe I need to change
src/component.jsL129 in order to enable resumption for trees that suspended during non-hydrate rendering:To-Do
preact-www