Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
In
mui
there's a concept offorking
a ref, this means that we combine the passed ref from the top with the one used internally inside a component to manage presentation.An example: https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Grow/Grow.js#L32
This becomes problematic in the following scenario
At this point we have evaluated
Wrapper
and moved thevnode.ref
tovnode.props.ref
due tooptions.vnode
being called (createVNode
). This makes theforking
of theGrow
ref fail since we talk tochildren.ref
which in this case isWrapper.ref
. That's why we move theforwarding
of refs to the point where we are going to diff theforwarded
component.Fixes: #2249