Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add svg typescript definitions #609

Merged
merged 3 commits into from
Mar 27, 2017
Merged

add svg typescript definitions #609

merged 3 commits into from
Mar 27, 2017

Conversation

juicelink
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.695% when pulling 60bda30 on juicelink:svg_type_definition into 0707442 on developit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.695% when pulling 60bda30 on juicelink:svg_type_definition into 0707442 on developit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.695% when pulling 4f5ce46 on juicelink:svg_type_definition into 0707442 on developit:master.

developit
developit reviewed Mar 25, 2017
View reviewed changes
src/preact.d.ts Outdated
y1?:number | string;
y2?:number | string;
y?:number | string;
accentHeight?:number | string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing seems off here

developit
developit reviewed Mar 25, 2017
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs to be tabs :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.695% when pulling 87f7666 on juicelink:svg_type_definition into 0707442 on developit:master.

@developit
Copy link
Member

Awesome, thanks!

@developit developit merged commit fc1e203 into preactjs:master Mar 27, 2017
@robertknight robertknight mentioned this pull request Apr 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juicelink @coveralls @developit