Simplify effect change checking (and make effect cycle detection more accurate as a side-effect) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa4cb7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: +233 B (0%) Total Size: 67.4 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Oct 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies effect change checking by removing the OUTDATED flag usage from effects. The flag itself can't be completely removed from the codebase, as computed signals still use it. Still, there are some delicious byte size savings gained from this change.
The OUTDATED flag became unnecessary after the changes introduced in #205.
As a nice side-effect the effect cycle detection is now more accurate. There is a new test case for that. The test case does collide with #231, and should be removed if/when that pull request is merged. The code simplifications are still valid regardless.