Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for context to propagate to components using context #381

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

JoviDeCroock
Copy link
Member

When a component utilises signals and one useContext that works with useState then context updates won't propagate as they are stopped by this condition

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

🦋 Changeset detected

Latest commit: 38635b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 38635b6
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/64a6d88190948e0008204454
😎 Deploy Preview https://deploy-preview-381--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Size Change: +262 B (0%)

Total Size: 69.3 kB

Filename Size Change
docs/dist/assets/index.********.js 1.08 kB +243 B (+29%) 🚨
docs/dist/assets/signals.module.********.js 1.98 kB +8 B (0%)
docs/dist/demos-********.js 3.35 kB +1 B (0%)
packages/preact/dist/signals.js 1.21 kB +6 B (0%)
packages/preact/dist/signals.mjs 1.15 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.6 kB
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/signals-core.module.********.js 1.42 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.48 kB
packages/core/dist/signals-core.mjs 1.5 kB
packages/react/dist/signals.js 1.25 kB
packages/react/dist/signals.mjs 1.21 kB

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@JoviDeCroock JoviDeCroock merged commit e655e7f into main Jul 6, 2023
@JoviDeCroock JoviDeCroock deleted the fix-context-propagation branch July 6, 2023 15:10
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants