Remove auto tracking using React internals from signals-react package #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id duplicate code when building
🦋 Changeset detectedLatest commit: 46ef04a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
developit
approved these changes
Dec 15, 2023
rschristian
reviewed
Dec 15, 2023
|
Size Change: -3.14 kB (-4%) Total Size: 81 kB
ℹ️ View Unchanged
|
Merged
|
Need documentation and examples on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, importing
@preact/signals-reactwould invoke side effects that hook into React internals to automatically track signals. This change removes those side effects and requires consumers to update their code to continue using signals in React.To continue the "auto-tracking" mechanism, users can import
@preact/signals-react/autoto keep the previous mechanism in place.I'm also adding support for the comment
@useSignalsand@noUseSignalsto be consistent with the hook people can use to track signals:useSignals().