Build segfaults on Node.js v16 if config contains empty middleware array #893

zgoda · 2021-10-31T11:26:27Z

Describe the bug
If config contains empty array of middlewares, wmr run build ends with segfault.

To Reproduce
Steps to reproduce the behavior:

Initialise new project with npm init wmr@latest myproject, cd to myproject
In wmr.config.mjs add middleware: [] to config object
Run npm run build
See error

Expected behavior
Build finishes successfully

Bug occurs with:

wmr or wmr start (development)
wmr build (production)
wmr serve

Desktop (please complete the following information):

OS: Ubuntu 20.04.3
Browser: N/A
Node Version: 16.13.0; NPM Version: 8.1.2
WMR Version: 3.7.2

Additional context
Sometimes build finishes fine if middleware is null or undefined but fails at random. When set to empty array build failed in 20/20 attempts.

The text was updated successfully, but these errors were encountered:

rschristian · 2021-10-31T22:02:10Z

Can you provide the error please?

I cannot reproduce, and I don't believe middlewares are used in any part of the build process.

zgoda · 2021-11-02T11:16:26Z

This is segfault.

$ npm run build

> build
> wmr build --prerender

Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating

Wrote 23Kb to disk:
  dist/index.html 460b
  dist/index.d5d2e732.js 17Kb
  dist/assets/style.e6ee4bcf.css 499b
  dist/chunks/prerender.ea3dab95.js 4.8Kb
  dist/chunks/index.fb97a71f.js 214b
Segmentation fault (core dumped)

Config that does not segfault:

import { defineConfig } from 'wmr';

// Full list of options: https://wmr.dev/docs/configuration
export default defineConfig({
    /* Your configuration here */
    alias: {
        react: 'preact/compat',
        'react-dom': 'preact/compat'
    }
});

Config that segfaults always:

import { defineConfig } from 'wmr';

// Full list of options: https://wmr.dev/docs/configuration
export default defineConfig({
    /* Your configuration here */
    alias: {
        react: 'preact/compat',
        'react-dom': 'preact/compat'
    },
    middleware: []
});

If middleware is null then segfaults happen at random.

rschristian · 2021-11-02T15:08:01Z

That's really interesting. Can you share the debug info? wmr build --debug

zgoda · 2021-11-02T16:21:04Z

And on Mac OS 11.6.1 (node & npm versions exactly as on my Linux box):

$ npm run build

> build
> wmr build --prerender

Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating

Wrote 23Kb to disk:
  dist/index.html 460b
  dist/index.8a0cfff0.js 17Kb
  dist/assets/style.e6ee4bcf.css 499b
  dist/chunks/prerender.c8def485.js 4.8Kb
  dist/chunks/index.a1e0eb1d.js 214b
Segmentation fault: 11

Debug output from MacOS:

$ node_modules/.bin/wmr build --prerender --debug
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
  wmr:config  {
  wmr:config    _: [],
  wmr:config    prerender: true,
  wmr:config    debug: true,
  wmr:config    cwd: '/Users/jarekzgoda/work/test0',
  wmr:config    public: 'public',
  wmr:config    out: '/Users/jarekzgoda/work/test0/dist',
  wmr:config    sourcemap: undefined,
  wmr:config    visualize: undefined,
  wmr:config    minify: true,
  wmr:config    root: '/Users/jarekzgoda/work/test0/public',
  wmr:config    plugins: [],
  wmr:config    output: [],
  wmr:config    middleware: [],
  wmr:config    features: { preact: true },
  wmr:config    alias: { react: 'preact/compat', 'react-dom': 'preact/compat' },
  wmr:config    customRoutes: [],
  wmr:config    prod: true,
  wmr:config    mode: 'build',
  wmr:config    env: {},
  wmr:config    overlayDir: '/Users/jarekzgoda/work/test0/dist',
  wmr:config    publicPath: '/',
  wmr:config    host: 'localhost'
  wmr:config  }
  npm:plugin  htm/preact -> npm/htm@3.1.0/preact/index.module.js
  npm:plugin  preact-iso -> npm/preact-iso@2.3.0/index.js
  npm:plugin  htm/preact -> npm/htm@3.1.0/preact/index.module.js
  npm:plugin  htm/preact -> npm/htm@3.1.0/preact/index.module.js
  npm:plugin  htm/preact -> npm/htm@3.1.0/preact/index.module.js
  npm:plugin  preact-iso -> npm/preact-iso@2.3.0/index.js
  npm:plugin  preact/hooks -> npm/preact@10.5.15/hooks/dist/hooks.module.js
  npm:plugin  htm/preact -> npm/htm@3.1.0/preact/index.module.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  htm -> npm/htm@3.1.0/dist/htm.module.js
  npm:plugin  ./router.js -> npm/preact-iso@2.3.0/router.js
  npm:plugin  ./lazy.js -> npm/preact-iso@2.3.0/lazy.js
  npm:plugin  ./hydrate.js -> npm/preact-iso@2.3.0/hydrate.js
  npm:plugin  ./prerender.js -> npm/preact-iso@2.3.0/prerender.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  preact/hooks -> npm/preact@10.5.15/hooks/dist/hooks.module.js
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
  npm:plugin  preact/hooks -> npm/preact@10.5.15/hooks/dist/hooks.module.js
  npm:plugin  preact-render-to-string -> npm/preact-render-to-string@5.1.19/dist/index.mjs
  npm:plugin  preact -> npm/preact@10.5.15/dist/preact.module.js
(!) minify(index.d5d2e732.js) took 200ms

Merging assets/style.module.83820528.css into assets/style.module.7b16dcc3.css (chunks/index.fb97a71f.js → index.d5d2e732.js)
Hoisting CSS "assets/style.module.7b16dcc3.css" imported by index.d5d2e732.js into parent HTML import "assets/style.e6ee4bcf.css".

Wrote 23Kb to disk:
  dist/index.html 460b
  dist/index.d5d2e732.js 17Kb
  dist/assets/style.e6ee4bcf.css 499b
  dist/chunks/prerender.ea3dab95.js 4.8Kb
  dist/chunks/index.fb97a71f.js 214b
Segmentation fault: 11

zgoda · 2021-11-02T16:33:44Z

Downgraded node to v14.18.1 and everything works fine again.

rschristian · 2021-11-16T03:59:13Z

Just wanted to comment that I too encountered some bizarre segfaults with Node 16, though it was entirely inconsistent and would occur seemingly post-prerender?

Output would be generated just fine, but 50% of the time I'd be hit with a lovely SIGSEGV before completion. Rerunning the build nearly always completed without any error.

Downgraded back to Node 14 too, no issues here. Really weird.

Edit: No config from me, so shouldn't be related to that in any way. Will try to track this down when I have some time, could just be buggy Node I suppose?

zgoda · 2021-11-16T09:41:05Z

I've seen less of segfaults after upgrading npm to some later version, 8.1.2 or 8.1.3.

rschristian · 2021-11-16T17:14:19Z

Interesting. Yarn for me, though did have latest NPM (8.1.3).

danielweck · 2022-01-03T22:47:15Z

I think this is a duplicate issue: #896 (comment)

I too am experiencing the random segmentation fault that prevents WMR prerender build from completing (missing HTML files in dist folder, and segfault in console). I am on MacOS, Node version 16.13.1, NPM version 8.3.0.

danielweck · 2022-01-03T22:50:13Z

...I should also point out that WMR config.middleware: [] doesn't yield 100% repro, it seems as random as config.middleware: undefined or config.middleware: null.

zgoda · 2022-01-04T17:22:48Z

Yes, it seems I was too quick assuming there's any relation.

developit · 2022-04-12T22:50:15Z

Should we close this as a duplicate of #896?

katopz · 2022-12-10T03:38:41Z

I can reproduce this on wmr, 3.8.0 by just

yarn create wmr hello-preact-wmr
yarn build

It's 60-70% chance to get SIGSEGV (this one hit at first try, i'm feeling lucky)

katopz@fox hello-preact-wmr % yarn build
yarn run v1.22.17
$ wmr build --prerender

Wrote 27Kb to disk:
  dist/index.html 460b
  dist/index.32c06713.js 18Kb
  dist/assets/style.e6ee4bcf.css 499b
  dist/chunks/prerender.e1448b15.js 8.1Kb
  dist/chunks/index.08589ee3.js 214b
error Command failed with signal "SIGSEGV".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

katopz@fox hello-preact-wmr % node --version && npm --version
v16.13.0
8.5.0

Not sure what the root cause is.

zgoda added the bug Something isn't working label Oct 31, 2021

zgoda changed the title ~~Build segfaults if config contains empty middleware array~~ Build segfaults on Node.js v16 if config contains empty middleware array Nov 2, 2021

zgoda mentioned this issue Nov 21, 2021

Prerendering not working on Node 16 #896

Open

3 tasks

danielweck mentioned this issue Jan 3, 2022

[WMR]: Stylesheets not clearing between pages being prerendered tw-in-js/use-twind-with#25

Closed

rschristian mentioned this issue Jan 8, 2022

Fix/jsx whitespace #900

Merged

developit added the duplicate This issue or pull request already exists label Apr 12, 2022

danielweck mentioned this issue Aug 16, 2022

Add globalThis.fetch #934

Merged

rschristian closed this as completed Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build segfaults on Node.js v16 if config contains empty middleware array #893

Build segfaults on Node.js v16 if config contains empty middleware array #893

zgoda commented Oct 31, 2021 •

edited

Loading

rschristian commented Oct 31, 2021

zgoda commented Nov 2, 2021 •

edited

Loading

rschristian commented Nov 2, 2021

zgoda commented Nov 2, 2021 •

edited

Loading

zgoda commented Nov 2, 2021

rschristian commented Nov 16, 2021 •

edited

Loading

zgoda commented Nov 16, 2021

rschristian commented Nov 16, 2021

danielweck commented Jan 3, 2022

danielweck commented Jan 3, 2022

zgoda commented Jan 4, 2022

developit commented Apr 12, 2022

katopz commented Dec 10, 2022 •

edited

Loading

Build segfaults on Node.js v16 if config contains empty middleware array #893

Build segfaults on Node.js v16 if config contains empty middleware array #893

Comments

zgoda commented Oct 31, 2021 • edited Loading

rschristian commented Oct 31, 2021

zgoda commented Nov 2, 2021 • edited Loading

rschristian commented Nov 2, 2021

zgoda commented Nov 2, 2021 • edited Loading

zgoda commented Nov 2, 2021

rschristian commented Nov 16, 2021 • edited Loading

zgoda commented Nov 16, 2021

rschristian commented Nov 16, 2021

danielweck commented Jan 3, 2022

danielweck commented Jan 3, 2022

zgoda commented Jan 4, 2022

developit commented Apr 12, 2022

katopz commented Dec 10, 2022 • edited Loading

zgoda commented Oct 31, 2021 •

edited

Loading

zgoda commented Nov 2, 2021 •

edited

Loading

zgoda commented Nov 2, 2021 •

edited

Loading

rschristian commented Nov 16, 2021 •

edited

Loading

katopz commented Dec 10, 2022 •

edited

Loading