Skip to content

Conversation

uekerman
Copy link
Member

@uekerman uekerman commented Feb 26, 2025

I promised in precice/precice#1907 to add a docs section on deadlocks in compositional coupling. I tried to add the simplest possible example.

The mermaid graph will probably not work on the website. Would this be easy to add? If not, I would add the comment in a comment and add the svg instead.

graph LR;
    A -- first to second --> B;
    B -- first to second --> C;
    C -- first to second --> A;
Loading

@fsimonis @carme-hp Enough information covered and would you prefer to see more examples and problems?

@orlandoisepic Could be a potential case for the checker a well.

@uekerman uekerman self-assigned this Feb 26, 2025
Copy link
Member

@carme-hp carme-hp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the explanation for the deadlock and its solution is clear:)

@fsimonis
Copy link
Member

fsimonis commented Feb 26, 2025

The mermaid graph will probably not work on the website. Would this be easy to add? If not, I would add the comment in a comment and add the svg instead.

Not difficult. But wouldn't it be neater to see an actual config visualization? You mentioned that you have a minimal example, right?

@orlandoisepic
Copy link

This error can only occur with serial coupling schemes? And is it possible to occur with two or more participants?

Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
@uekerman
Copy link
Member Author

@fsimonis

But wouldn't it be neater to see an actual config visualization? You mentioned that you have a minimal example, right?

https://github.com/precice/precice/blob/develop/tests/serial/circular/Explicit.xml and swap participants in line 65. In the config visualization the coupling scheme is separated from the exchanges, right?

@uekerman
Copy link
Member Author

@orlandoisepic

This error can only occur with serial coupling schemes?

yes

And is it possible to occur with two or more participants?

You need at least three participant to get such a circular dependency. For two participants, you can only define one coupling scheme.

Comment on lines 51 to 56
```mermaid
graph LR;
A -- first to second --> B;
B -- first to second --> C;
C -- first to second --> A;
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work at the moment: #552

@uekerman
Copy link
Member Author

Merging here. Let's add the mermaid graph eventually, see #552

@uekerman uekerman merged commit c409ae5 into master Jul 17, 2025
2 checks passed
@MakisH MakisH deleted the extend-compositional-docs branch August 27, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants