-
-
Notifications
You must be signed in to change notification settings - Fork 76
Right-align the details marker #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! Do you have screenshots of how this would look like when rendered? That would make the PR easier to review. |
The CI is failing to build the website from this PR: https://github.com/precice/precice.github.io/actions/runs/17377997579/job/49330210240?pr=582 |
The
The Ruby version is fixed in https://github.com/precice/precice.github.io/blob/master/.ruby-version You could try updating the version there and see what happens. |
1a2e05e
to
3a76e6a
Compare
adc621c
to
7b4cfc7
Compare
I force-pushed a cleaned branch so that it now contains only the intended change: Update to css/customstyles-precice.css (custom toggle arrows replacing the default disclosure marker). All unrelated changes (Gemfile, submodules, forum page, etc.) have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning up!
That's good enough for now and is consistent with our sidebar.
In the future, we could make this even clearer.
Replace default details marker with custom toggle arrows (▼/▲) and update Gemfile
Description
This PR introduces two improvements:
Custom toggle arrows for/
Gemfile update for compatibility