Skip to content

Conversation

BytePaul
Copy link
Contributor

@BytePaul BytePaul commented Sep 1, 2025

Replace default details marker with custom toggle arrows (▼/▲) and update Gemfile

Description

This PR introduces two improvements:

Custom toggle arrows for
/

  • Removed the default browser disclosure marker.
  • Added a right-aligned ▼ (closed) and ▲ (open).
  • Improves clarity and visual consistency in workshop event sections.

Gemfile update for compatibility

  • Updated dependencies to support the latest Ruby/Jekyll versions.
  • Resolves issues with outdated versions during local builds.

@MakisH
Copy link
Member

MakisH commented Sep 1, 2025

Thanks for the PR! Do you have screenshots of how this would look like when rendered? That would make the PR easier to review.

@BytePaul
Copy link
Contributor Author

BytePaul commented Sep 1, 2025

Sure!
improved_style

@MakisH
Copy link
Member

MakisH commented Sep 1, 2025

The CI is failing to build the website from this PR: https://github.com/precice/precice.github.io/actions/runs/17377997579/job/49330210240?pr=582

@MakisH
Copy link
Member

MakisH commented Sep 3, 2025

The setup-ruby action fails with:

Installing Bundler
  Using Bundler 2.7.1 from Gemfile.lock BUNDLED WITH 2.7.1
  /opt/hostedtoolcache/Ruby/3.0.7/x64/bin/gem install bundler -v 2.7.1
  ERROR:  Error installing bundler:
  	bundler-2.7.1 requires Ruby version >= 3.2.0. The current ruby version is 3.0.7.220.

The Ruby version is fixed in https://github.com/precice/precice.github.io/blob/master/.ruby-version

You could try updating the version there and see what happens.

@BytePaul BytePaul force-pushed the feature/details-toggle-icon branch from 1a2e05e to 3a76e6a Compare September 15, 2025 14:00
@BytePaul BytePaul force-pushed the feature/details-toggle-icon branch from adc621c to 7b4cfc7 Compare October 3, 2025 20:14
@BytePaul
Copy link
Contributor Author

BytePaul commented Oct 3, 2025

I force-pushed a cleaned branch so that it now contains only the intended change:

Update to css/customstyles-precice.css (custom toggle arrows replacing the default disclosure marker).

All unrelated changes (Gemfile, submodules, forum page, etc.) have been removed.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up!

That's good enough for now and is consistent with our sidebar.
In the future, we could make this even clearer.

@MakisH MakisH changed the title replace default details marker with custom toggle arrows Right-align the details marker Oct 6, 2025
@MakisH MakisH added the technical Technical issues on the website label Oct 6, 2025
@MakisH MakisH self-assigned this Oct 6, 2025
@MakisH MakisH merged commit f37c0ae into precice:master Oct 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Technical issues on the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants