Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve parsing errors of pypi-dependencies #1871

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: improve parsing errors of pypi-dependencies #1871

merged 1 commit into from
Aug 21, 2024

Conversation

ruben-arts
Copy link
Contributor

Further improves #1858

Not sure why the formatting is weird but at least it tells you the actual problem:
image
Custom error:
image

baszalmstra
baszalmstra approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

There seems to be a lot of duplication here. Perhaps we can split this into a crate later?

@ruben-arts
Copy link
Contributor Author

ruben-arts commented Aug 21, 2024 •
edited
Loading

@baszalmstra, yeah a crate would be great.

@ruben-arts ruben-arts merged commit b600282 into prefix-dev:main Aug 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-arts @baszalmstra