Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add completion evaluation to the activation of the shell on install #293

Conversation

ruben-arts
Copy link
Contributor

This adds the pixi completion command to the activation of a shell on installation. This should make the initial setup easier.

Related to #292

install/install.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
@wolfv
Copy link
Member

wolfv commented Aug 29, 2023

Would it be better to do it like rye and place a file in ~/.pixi/env.sh or so that does both these actions? That way we would only ever have to add one line to the .bashrc file, and it would be easier to remove / change.

@baszalmstra
Copy link
Contributor

With #316 the original need for this PR will be removed. But should we still add this? I assume the user has to give consent?

We also have to incorporate changes from #325

@ruben-arts ruben-arts marked this pull request as draft September 21, 2023 07:24
@ruben-arts
Copy link
Contributor Author

Closing this as there is no real NEED for this to make pixi work. We could revisit it later if ther're more ideas on it.

@ruben-arts ruben-arts closed this Oct 18, 2023
@ruben-arts ruben-arts deleted the feat/add_completion_to_shell_activation branch February 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants