Fix individual dashboard upload when filter datasets are not the same as in charts #269
Conversation
|
|
|
Hi @grvoicu, Thank you so much for contributing this fix to the CLI. Since the CLI is under an We also have a 100% test coverage requirement in the repository, so we might need to add a few test cases (and review any test that might break with changes) to be able to merge it. Would you like to proceed with this contribution? If so please sign the CLA, and let me know if you would need assistance with the tests. Thank you! |
|
Hey @grvoicu, Wondering if you had a chance to check my message. Thank you! |
| Extract native filters dataset UUID from a dashboard config. | ||
| """ | ||
| uuids = set() | ||
| for child in config["metadata"]["native_filter_configuration"]: |
There was a problem hiding this comment.
This might actually fail for dashboard without either metadata nor native_filter_configuration attributes. Better to add
if config.get('metadata') and config['metadata'].get('native_filter_configuration'):
|
Closing in favor of #292 |
Preset supports dashboards with filters on different datasets than the datasets used by the charts. currently, individually uploading such a dashboard with Preset CLI fails, because the filters datasets are not included in the list of dependencies for the dashboard asset.
Note: I consider having dashboard filters on different datasets than the datasets used by the charts is not a bug, but a feature. An example where this is useful: a dataset with all the countries in the world and multiple datasets, each one with data for a subset of countries. A filter on the world countries dataset can then be applied to any dashboard, without having to take care to know which dataset is used in the dashboard charts. As long as the country column is named the same and the values are consistent across all datasets it will work.