Add obsolete entries to comparison report #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include "obsolete" (warnings in the ignore configuration that are no longer present) fingerprints in report when using
--compare.{ "new": [ ], "fixed": [ ], "obsolete": [ ] }This isn't particularly smart - it just reports the obsolete fingerprints just like the text report would for a new scan. It doesn't differentiate between already-obsolete and newly-obsolete.
In other words, if there were ignored warnings that were already missing in the original report, they will still be reported as obsolete in the new report.
Fixes #1758
Also update the test for comparison report to be more modern.