Stop alerting for Mass Assignment on #update_attribute
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This belongs in the annotations branch This reverts commit fafdac2.
when rendering and when dealing with filters
when target is a model
because the next RubyParser release is going to break a LOT of stuff.
also fixes issue with sometimes returning hash inside hash
just like Sexp#line(line)
and get a free performance boost, yay!
Sexp#line can be used to retrieve or set the line number. No need to invalidate the hash cache if line is not being set.
check already exists, but no tests for it
Again, the check for this already exists, just need a test for it
where it makes sense
presidentbeef
added a commit
that referenced
this pull request
Apr 19, 2012
Stop alerting for Mass Assignment on `#update_attribute`
Repository owner
locked and limited conversation to collaborators
Feb 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Issue #80