0.2.3

[vtemian]

No description provided.

[calind]

we should move these raven imports inside if args.sentry_dsn: so we do not have hard dependency on raven module.

[vtemian]

but if you install it from ppa and built it with pex, it would pe harder to work like that

[calind]

We should drop socket.gethostname() as it's a rather expensive syscall. If it's configured for raven i think it does this automatically, or if it doesn't we should use http://raven.readthedocs.org/en/latest/usage.html#raven.base.Client.context

[vtemian]

I don't think that raven do it by default and if socket.gethostname is to
expensive, we could use os.environ["HOSTNAME"]. If we don't append it in
message and send it using context or tags, we still need to get the
hostname

On Wed, Nov 12, 2014 at 7:28 PM, Calin Don notifications@github.com wrote:

In gitfs/router.py:

@@ -126,7 +127,13 @@ def call(self, operation, *args):
view.class.name))
raise FuseOSError(ENOSYS)

•    return getattr(view, operation)(*args)
  

•    try:
  

•        return getattr(view, operation)(*args)
  

•    except FuseOSError as e:
  

•        raise e
  

•    except Exception as exception:
  

•        log.exception("[%s] A system call failed" % socket.gethostname())
  

We should drop socket.gethostname() as it's a rather expensive syscall.
If it's configured for raven i think it does this automatically, or if it
doesn't we should use
http://raven.readthedocs.org/en/latest/usage.html#raven.base.Client.context

—
Reply to this email directly or view it on GitHub
https://github.com/PressLabs/gitfs/pull/162/files#r20234633.

Vlad

[calind]

Just checked. raven and it automatically adds the server. Check http://sentry.presslabs.net/production/gitfs/group/692/ right column.

[vtemian]

Cool

On Wed, Nov 12, 2014 at 7:40 PM, Calin Don notifications@github.com wrote:

In gitfs/router.py:

@@ -126,7 +127,13 @@ def call(self, operation, *args):
view.class.name))
raise FuseOSError(ENOSYS)

•    return getattr(view, operation)(*args)
  

•    try:
  

•        return getattr(view, operation)(*args)
  

•    except FuseOSError as e:
  

•        raise e
  

•    except Exception as exception:
  

•        log.exception("[%s] A system call failed" % socket.gethostname())
  

Just checked. raven and it automatically adds the server. Check
http://sentry.presslabs.net/production/gitfs/group/692/ right column.

—
Reply to this email directly or view it on GitHub
https://github.com/PressLabs/gitfs/pull/162/files#r20235478.

Vlad

[calind]

Also check the above comment.

[sourcegraphbot]

 router.Router.__call__.e

 router.Router.__call__.exception

 args.Args.check_args.sentry_handler

 args.Args.get_sentry_dsn

 args.Args.get_sentry_dsn.args

 args.Args.get_sentry_dsn.self

 fetch.FetchWorker.work

 fetch.FetchWorker.work.self

 peasant.Peasant.run

 peasant.Peasant.run.self

Showing only the first ten definitions. View the rest on ✱ sourcegraph.com

---

View the full smart diff on ✱ sourcegraph.com

Disable sourcegraphbot for this repository.