-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertica driver support #393
Conversation
Seems reasonable, I have not personally used vertica, but judging by the queries it seems pretty straightforward. I presume we can use a docker container, such as: |
I was able to get the container to work with a few modifications to reduce the startup time:
Only one instance of Vertica can be running on a host at any time so I put all assertions into one unit test. |
@mfridman I'd love to see this merged. Any concerns on your end? |
No concerns with the PR itself, more concern about the ongoing maintenance. I'm not familiar with vertica DB, so if users start filing issues/ask questions there is an additional maintenance cost to the current and future maintainers. I'm starting to think there might be "official" and "third-party" goose support for the various databases and drivers. |
What do you think about instead of this PR just exporting the functions on the SQLDialect interface so it can be implemented outside the goose package and offering something like:
|
Interesting idea, but that would mean you could only use it from the golang API right, and the cli would not work? |
Hey @bobpace, if you're up for it, can you rebase (or merge) |
That sounds great, thanks! |
vertica-sql-go
dependency!no_vertica
build tag indriver_vertica.go
I've been using these changes successfully already with a custom build of
goose
to manage vertica migrations for a project. I'm willing to include test coverage similar to what has been done for other drivers if there is interest in accepting this PR. Let me know if there is any other feedback you have for me that I may have missed. Thanks!