Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with error 1 without required arguments #399

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

el4v
Copy link
Contributor

@el4v el4v commented Aug 24, 2022

When no argument or variable is given, the program exits with an exit code of 0 as if the migration process was successfully completed.

You must exit with exit code 1 to determine that the migration failed.

Copy link
Collaborator

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need the same for len(args) == 0 above?

@el4v
Copy link
Contributor Author

el4v commented Aug 24, 2022

Yes, I think it's helpful too. added

@el4v
Copy link
Contributor Author

el4v commented Aug 25, 2022

can you accept the PR and release it? Thank you

Copy link
Collaborator

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfridman mfridman merged commit 8abd890 into pressly:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants