-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for *sql.DB
-registered Go migration
#450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Thanks for your help @cbodonnell, if I find some time I'll try and capture this in a blog post over on the goose docs. |
Nice work. Thanks @mfridman @cbodonnell 🎉 |
cool thanks. Any ETA for |
Likely by the end of next week (if not earlier), I'd like to get a few other PR's into that release. |
Fixes #201 #386 #324
Most of this code is ported over from the large provider branch #378.
This PR adds logic to support
*sql.DB
-registered Go migrations. We technically do not need the function types, but I found these extremely useful. This should be backwards-compatible.The new functions to add/register migrations are:
*sql.DB
and*sql.Tx
-style Go migrations