Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add golangci-lint #456

Merged
merged 1 commit into from
Jan 27, 2023
Merged

ci: add golangci-lint #456

merged 1 commit into from
Jan 27, 2023

Conversation

mfridman
Copy link
Collaborator

@mfridman mfridman commented Jan 27, 2023

Fix #453

This PR introduces golangci-lint to the project, which is run on every push to master/main and on every PR. The full documentation can be found here, and we can tune it as things come up.

If we don't like it, we'll remove it.

There are also two helpful make targets:

make tools
make lint

^ this should is effectively what CI will run.

The default linters are already pretty helpful:

errcheck
gosimple
govet
ineffassign
staticcheck
typecheck
unused

@mfridman mfridman changed the title [WIP] - testing out a linter ci: add golangci-lint Jan 27, 2023
@mfridman mfridman marked this pull request as ready for review January 27, 2023 13:28
@mfridman mfridman merged commit 32ad603 into master Jan 27, 2023
@mfridman mfridman deleted the gh-453-lint branch January 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: add a Go linter
1 participant