Bump minimum Go version to 1.18 (update CI) #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
changed the title
mfridman
commented
Feb 2, 2023
| @@ -14,7 +14,7 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
| - uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.19.x | |||
| go-version: "1.19" | |||
There was a problem hiding this comment.
The lint GitHub action is likely not ready for 1.20, which is fine. We'll wait until it's supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the module to a minimum Go version of 1.18.
We also update all the dependencies (including ClickHouse, which had breaking changes on a minor, hence we couldn't merge #447)
Will probably let this sit until go1.20 is officially released in February 2023.
EDIT: go1.20 landed, so this is good to go.