Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azuresql dialect #487

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

sblackstone
Copy link
Contributor

@sblackstone sblackstone commented Mar 28, 2023

The MSSQL driver has different driver names based on whether your connecting with a ManagedIdentity or by password.

This corresponds to https://github.com/microsoft/go-mssqldb/tree/main/azuread

This small patch adds support for azuresql driver and treats it as a synonym to sqlserver

@mfridman
Copy link
Collaborator

Hehe, thanks. This is the kind of thing I'm hoping to avoid (in /v4), i.e., the goose package should be initialized with a dialect but the *sql.DB connection should be supplied by the caller.

That way anyone can use whatever driver they want, and match it up to a dialect that makes sense for their database technology.

This also makes it more extensible into the future when new drivers are added by the community.

@mfridman mfridman merged commit 49c55f0 into pressly:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants