-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use global table name in store queries #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunk-s
pushed a commit
to arunk-s/goose
that referenced
this pull request
May 16, 2023
nicolerenee
pushed a commit
to infratographer/x
that referenced
this pull request
May 25, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pressly/goose/v3](https://togithub.com/pressly/goose) | require | minor | `v3.10.0` -> `v3.11.2` | --- ### Release Notes <details> <summary>pressly/goose</summary> ### [`v3.11.2`](https://togithub.com/pressly/goose/releases/tag/v3.11.2) [Compare Source](https://togithub.com/pressly/goose/compare/v3.11.1...v3.11.2) #### Changelog - Add validate command to help and readme in [pressly/goose#512 - fix: use global table name in store queries in [pressly/goose#515. Fixes a **regression** reported in [pressly/goose#514 - build: upgrade deps in [pressly/goose#516 **Full Changelog**: pressly/goose@v3.11.0...v3.11.2 ### [`v3.11.1`](https://togithub.com/pressly/goose/compare/v3.11.0...v3.11.1) [Compare Source](https://togithub.com/pressly/goose/compare/v3.11.0...v3.11.1) ### [`v3.11.0`](https://togithub.com/pressly/goose/releases/tag/v3.11.0) [Compare Source](https://togithub.com/pressly/goose/compare/v3.10.0...v3.11.0) #### Changelog - [`ba6e5fb`](https://togithub.com/pressly/goose/commit/ba6e5fb6f00f4ca35fea83963dc7e6622832d3f8): Add 'sqlserver' to dialects as an alias of mssql ([#​510](https://togithub.com/pressly/goose/issues/510)) ([@​ffaen](https://togithub.com/ffaen)) - [`3e0905a`](https://togithub.com/pressly/goose/commit/3e0905abacffc8cd736617b8ce3c8a724db7e2bb): build(deps): bump github.com/opencontainers/runc from 1.1.4 to 1.1.5 ([#​488](https://togithub.com/pressly/goose/issues/488)) ([@​dependabot](https://togithub.com/dependabot)\[bot]) - [`4eee07f`](https://togithub.com/pressly/goose/commit/4eee07f48a5c72b08925bb7bd787524af48a294b): build(deps): bump github.com/ory/dockertest/v3 from 3.9.1 to 3.10.0 ([#​504](https://togithub.com/pressly/goose/issues/504)) ([@​dependabot](https://togithub.com/dependabot)\[bot]) - [`86f779a`](https://togithub.com/pressly/goose/commit/86f779a9590e4edba5d2620b7ce88dc6d30a0580): build: add Linux ARM64 arch support ([#​499](https://togithub.com/pressly/goose/issues/499)) ([@​jesusprubio](https://togithub.com/jesusprubio)) - [`0bc0034`](https://togithub.com/pressly/goose/commit/0bc00342b57dd894593b5bac154776cc06943ef6): build: upgrade deps and update workflows ([#​500](https://togithub.com/pressly/goose/issues/500)) ([@​mfridman](https://togithub.com/mfridman)) - [`99204d2`](https://togithub.com/pressly/goose/commit/99204d2421167fe254eeb8345f1aa7e3823740ac): build: upgrade to github.com/jackc/pgx/v5 ([#​475](https://togithub.com/pressly/goose/issues/475)) ([@​dahu33](https://togithub.com/dahu33)) - [`15ef2bc`](https://togithub.com/pressly/goose/commit/15ef2bcb6e6b6f38de5519dff5e57c6480373b00): chore: fix comment typos ([#​480](https://togithub.com/pressly/goose/issues/480)) ([@​deining](https://togithub.com/deining)) - [`33106fc`](https://togithub.com/pressly/goose/commit/33106fc6f2794885be83db34feac1a17b0462e99): chore: update annotation comments ([#​478](https://togithub.com/pressly/goose/issues/478)) ([@​mfridman](https://togithub.com/mfridman)) - [`0d1296b`](https://togithub.com/pressly/goose/commit/0d1296b2bbb3e88b4920c9441beb98bfefc23a5d): feat(mssql): update driver to microsoft/go-mssqldb ([#​501](https://togithub.com/pressly/goose/issues/501)) ([@​mfridman](https://togithub.com/mfridman)) - [`49c55f0`](https://togithub.com/pressly/goose/commit/49c55f0f984eda9e57229f0f515bd09143cc1f17): feat: add support for azuresql dialect ([#​487](https://togithub.com/pressly/goose/issues/487)) ([@​sblackstone](https://togithub.com/sblackstone)) - [`e2ecb28`](https://togithub.com/pressly/goose/commit/e2ecb28d00ece625482f4f5de4397da34825ea14): fix: clickhouse tests ([@​mfridman](https://togithub.com/mfridman)) - [`c462979`](https://togithub.com/pressly/goose/commit/c462979327385eb7bf68e5bf2e232e8fbd3f9773): refactor: create a generic store and stub out dialect queries ([#​477](https://togithub.com/pressly/goose/issues/477)) ([@​mfridman](https://togithub.com/mfridman)) - [`baaec13`](https://togithub.com/pressly/goose/commit/baaec139e4ebc44db20ea46f133b7ddf1b9c5bb7): refactor: dialectquery ([#​482](https://togithub.com/pressly/goose/issues/482)) ([@​mfridman](https://togithub.com/mfridman)) - [`8574431`](https://togithub.com/pressly/goose/commit/8574431aadfdbc2978623d7d5c859d80fdb7cbd3): refactor: remove deprecated ioutil ([@​mfridman](https://togithub.com/mfridman)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/infratographer/x). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTguNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression reported in #514.
Instead of initializing the table once (coupled with the store), we have to use the global table name. The fix here is to pass the table name down to the querier through the
Store
.