New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetTableName doesn't work anymore (regression in v3.11.0) #514

Closed

oscar-weave opened this issue May 8, 2023 · 3 comments

Labels

bug

oscar-weave commented May 8, 2023

As of goose v3.11.0 goose.Up() no longer uses the table name configured with goose.SetTableName() and instead uses the default table name goose_db_version. Reverting back to v3.10.0 resolves the issue.

I strongly suspect that this commit is the cause of this regression: c462979

Note that goose.TableName() still returns the table name set with goose.SetTableName(), it's just that goose doesn't use that table name anymore to select/insert migrations.

The text was updated successfully, but these errors were encountered:

Collaborator

mfridman commented May 8, 2023

Thanks for reporting the issue, I'll get that fixed up.

I believe the code makes an assumption that SetTableName is called before SetDialect, but that's incorrect because these are globals and can be modified anytime.

mfridman added the bug label

mfridman mentioned this issue

fix: use global table name in store queries #515

Merged

Collaborator

mfridman commented May 8, 2023

@oscar-weave, this issue should be resolved in v3.11.2.

Going to close this, but if you continue to run into issues let us know.

mfridman closed this as completed

Author

oscar-weave commented May 8, 2023

@mfridman Awesome. And thanks for the quick response!

nicolerenee pushed a commit to infratographer/x that referenced this issue


          fix(deps): update module github.com/pressly/goose/v3 to v3.11.2 (#57)

607a816

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/pressly/goose/v3](https://togithub.com/pressly/goose) |
require | minor | `v3.10.0` -> `v3.11.2` |

---

### Release Notes

<details>
<summary>pressly/goose</summary>

### [`v3.11.2`](https://togithub.com/pressly/goose/releases/tag/v3.11.2)

[Compare
Source](https://togithub.com/pressly/goose/compare/v3.11.1...v3.11.2)

#### Changelog

- Add validate command to help and readme in
[pressly/goose#512
- fix: use global table name in store queries in
[pressly/goose#515.
Fixes a **regression** reported in
[pressly/goose#514
- build: upgrade deps in
[pressly/goose#516

**Full Changelog**:
pressly/goose@v3.11.0...v3.11.2

###
[`v3.11.1`](https://togithub.com/pressly/goose/compare/v3.11.0...v3.11.1)

[Compare
Source](https://togithub.com/pressly/goose/compare/v3.11.0...v3.11.1)

### [`v3.11.0`](https://togithub.com/pressly/goose/releases/tag/v3.11.0)

[Compare
Source](https://togithub.com/pressly/goose/compare/v3.10.0...v3.11.0)

#### Changelog

-
[`ba6e5fb`](https://togithub.com/pressly/goose/commit/ba6e5fb6f00f4ca35fea83963dc7e6622832d3f8):
Add 'sqlserver' to dialects as an alias of mssql
([#&#8203;510](https://togithub.com/pressly/goose/issues/510))
([@&#8203;ffaen](https://togithub.com/ffaen))
-
[`3e0905a`](https://togithub.com/pressly/goose/commit/3e0905abacffc8cd736617b8ce3c8a724db7e2bb):
build(deps): bump github.com/opencontainers/runc from 1.1.4 to 1.1.5
([#&#8203;488](https://togithub.com/pressly/goose/issues/488))
([@&#8203;dependabot](https://togithub.com/dependabot)\[bot])
-
[`4eee07f`](https://togithub.com/pressly/goose/commit/4eee07f48a5c72b08925bb7bd787524af48a294b):
build(deps): bump github.com/ory/dockertest/v3 from 3.9.1 to 3.10.0
([#&#8203;504](https://togithub.com/pressly/goose/issues/504))
([@&#8203;dependabot](https://togithub.com/dependabot)\[bot])
-
[`86f779a`](https://togithub.com/pressly/goose/commit/86f779a9590e4edba5d2620b7ce88dc6d30a0580):
build: add Linux ARM64 arch support
([#&#8203;499](https://togithub.com/pressly/goose/issues/499))
([@&#8203;jesusprubio](https://togithub.com/jesusprubio))
-
[`0bc0034`](https://togithub.com/pressly/goose/commit/0bc00342b57dd894593b5bac154776cc06943ef6):
build: upgrade deps and update workflows
([#&#8203;500](https://togithub.com/pressly/goose/issues/500))
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`99204d2`](https://togithub.com/pressly/goose/commit/99204d2421167fe254eeb8345f1aa7e3823740ac):
build: upgrade to github.com/jackc/pgx/v5
([#&#8203;475](https://togithub.com/pressly/goose/issues/475))
([@&#8203;dahu33](https://togithub.com/dahu33))
-
[`15ef2bc`](https://togithub.com/pressly/goose/commit/15ef2bcb6e6b6f38de5519dff5e57c6480373b00):
chore: fix comment typos
([#&#8203;480](https://togithub.com/pressly/goose/issues/480))
([@&#8203;deining](https://togithub.com/deining))
-
[`33106fc`](https://togithub.com/pressly/goose/commit/33106fc6f2794885be83db34feac1a17b0462e99):
chore: update annotation comments
([#&#8203;478](https://togithub.com/pressly/goose/issues/478))
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`0d1296b`](https://togithub.com/pressly/goose/commit/0d1296b2bbb3e88b4920c9441beb98bfefc23a5d):
feat(mssql): update driver to microsoft/go-mssqldb
([#&#8203;501](https://togithub.com/pressly/goose/issues/501))
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`49c55f0`](https://togithub.com/pressly/goose/commit/49c55f0f984eda9e57229f0f515bd09143cc1f17):
feat: add support for azuresql dialect
([#&#8203;487](https://togithub.com/pressly/goose/issues/487))
([@&#8203;sblackstone](https://togithub.com/sblackstone))
-
[`e2ecb28`](https://togithub.com/pressly/goose/commit/e2ecb28d00ece625482f4f5de4397da34825ea14):
fix: clickhouse tests
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`c462979`](https://togithub.com/pressly/goose/commit/c462979327385eb7bf68e5bf2e232e8fbd3f9773):
refactor: create a generic store and stub out dialect queries
([#&#8203;477](https://togithub.com/pressly/goose/issues/477))
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`baaec13`](https://togithub.com/pressly/goose/commit/baaec139e4ebc44db20ea46f133b7ddf1b9c5bb7):
refactor: dialectquery
([#&#8203;482](https://togithub.com/pressly/goose/issues/482))
([@&#8203;mfridman](https://togithub.com/mfridman))
-
[`8574431`](https://togithub.com/pressly/goose/commit/8574431aadfdbc2978623d7d5c859d80fdb7cbd3):
refactor: remove deprecated ioutil
([@&#8203;mfridman](https://togithub.com/mfridman))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/infratographer/x).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTguNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment