Add homebrew #56
Add homebrew #56
Conversation
|
This is a great idea. Let's give this a test drive and submit to homebrew. |
|
thanks @kureikain |
|
|
||
| go_resource "gopkg.in/yaml.v2" do | ||
| url "https://gopkg.in/yaml.v2.git", :revision => "f7716cbe52baa25d2e9b0d0da546fcf909fc16b4" | ||
| end |
There was a problem hiding this comment.
Can we run make tools deps install or go get -u github.com/pressly/sup/cmd/sup instead of pulling all the above dependencies manually?
There was a problem hiding this comment.
They prefer to use go_resource
|
@kureikain nice, this will be really useful :) |
| @@ -0,0 +1,41 @@ | |||
| require "language/go" | |||
There was a problem hiding this comment.
Can we move this file under release/ directory? One day, when we reach v1.0, we should probably try to open PR against https://github.com/Homebrew/homebrew/tree/master/Library/Formula
There was a problem hiding this comment.
Yes, will update it.
I actually open a PR on homebrew Homebrew/legacy-homebrew#48230.
Later on, we probably should have some automation process to update and send PRs to homebrew use the sup.rb version on this repository as the source.
There was a problem hiding this comment.
Oh, nice! So in that case, do we even need the file in this repository too?
There was a problem hiding this comment.
I'm not really sure if we should keep them in this repository or just rely on homebew and a package maintainer.
However, my opinion is that we should keep this file in release/sup.rb as a source of truth. And later on we may have some make release_brew that automatically checkout and push a branch on the dev account(like pressly/homebrew). Then the dev simply create a PR on homebrew using github UI.
It also help power user who may run: brew install https://raw.githubusercontent.com/pressly/sup/master/release/sup.rb if homebrew doesn't merge quickly for whatever reason.
There was a problem hiding this comment.
Alright, let's merge this then (after v0.4 bump). Thanks for explanation.
|
Totally agree, awesome idea 👍 |
This allow people to install it via homebrew on Mac OSX like:
We can test this locallly with
brew install sup.rb