This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
add ssl configurations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelino
requested review from
crgimenes and
a team
and removed request for
crgimenes
|
That PR depends on this prest/config#13 |
|
maybe it's interesting to return an error if sslmode!=disable but the other required parameters are not filled. |
|
@crgimenes the problem is that even if I put mode=require, I don't need to fill the other parameters. |
felipeweb
pushed a commit
that referenced
this pull request
Oct 29, 2017
* Support access to all databases in PostgreSQL cluster * Fix broken SetNativeDB used for test purposes * Joel conflicts and merge manualy (#26) * restructuring for use of more than one database adapter * created Adapter interface * moved scanner to adapter * created Postgres type as Adapter * used config.Adapter to call the functions Signed-off-by: Joel M. de Souza <contato@joelmdesouza.com> * travis ci test * revised tests * revert test travis * revert test travis * changed onfig.Adapter to onfig.PrestConf.Adapter * pass Postgres{} as a reference * chanded adapter Postgres > adapter *Postgres * changed tests Postgres{} > config.PrestConf.Adapter * resolve conflicts adapter/scanner.go * fix some merge conflicts * Support access to all databases in PostgreSQL cluster * Fix broken SetNativeDB used for test purposes * add ssl configurations (#24) * Adjust to new Adapter interface * Support access to all databases in PostgreSQL cluster * Adjust to new Adapter interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of issue 234