Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prettier-eslint #14

Closed
esbenp opened this issue Jan 13, 2017 · 15 comments
Closed

Add support for prettier-eslint #14

esbenp opened this issue Jan 13, 2017 · 15 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@esbenp
Copy link
Contributor

esbenp commented Jan 13, 2017

https://github.com/kentcdodds/prettier-eslint

@colek42
Copy link
Contributor

colek42 commented Jan 13, 2017

This will let me get rid of my git hooks!

@replete
Copy link

replete commented Jan 13, 2017

This would be fantastic!

@CiGit
Copy link
Member

CiGit commented Jan 29, 2017

There are more project which you may consider
projects

@CiGit
Copy link
Member

CiGit commented Mar 4, 2017

Some thoughts about prettier-eslint:
I would expect people using eslint to also have the Eslint extension. So I think it would be possible to call eslint.executeAutoFix after having run prettier. (Cross-extension call)

@CiGit
Copy link
Member

CiGit commented Apr 8, 2017

It's done by https://marketplace.visualstudio.com/items?itemName=RobinMalfait.prettier-eslint-vscode
Closing

@batjko
Copy link

batjko commented Jul 10, 2017

Has this been removed from the vscode extension store?
Suddenly disabled in my editor and I can't find it in the list anymore:
image

@RobinMalfait
Copy link
Contributor

@batjko I removed the prettier-eslint extension from the store.

Good news: You can enable prettier.eslintIntegration using this plugin! So there was no need to keep supporting that other extension.

@batjko
Copy link

batjko commented Jul 10, 2017

@RobinMalfait Well that's good to know. I'm a little taken aback that an extension can just be uninstalled from my local editor without my knowledge. Some deprecation announcement would have been nice as well.

@RobinMalfait
Copy link
Contributor

@batjko There was a deprecation notice, after that I removed it.

@bySabi
Copy link

bySabi commented Jul 10, 2017

I add two extension to market-place. It just prettier-vscode patched for use semistandard or standard in place of eslint

This is the patcher: https://github.com/bySabi/patch--prettier-vscode

@batjko
Copy link

batjko commented Jul 10, 2017

@RobinMalfait Sorry I didn't see anything in the editor. Was it just on Github or something?
I don't think people can be reasonably expected to regularly revisit all their extension's homepages just to check if they may get removed soon.

Anyway, it's not a big deal, but clearly communication for such cases could be better - perhaps a notification inside the editor?

@RobinMalfait
Copy link
Contributor

@batjko I will do that the next time, if I have no other things to do ;)

@CiGit
Copy link
Member

CiGit commented Jul 10, 2017

That make me think, we should update JavaScript formatter ...
@batjko I'm surprised vscode silently uninstalled a deprecated extension, instead of just preventing it's installation.

@batjko
Copy link

batjko commented Jul 10, 2017

@batjko I'm surprised vscode silently uninstalled a deprecated extension, instead of just preventing it's installation.

So was I. I was wondering why my code suddenly doesn't get re-formatted anymore. I check my extensions and it was simply gone. It's not necessarily an issue with this extension, but with how VSC handles the deprecation of extensions, if this is possible.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

7 participants