Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #242

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Release tracking #242

merged 1 commit into from
Apr 27, 2023

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Apr 20, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/brand-primitives@0.17.0

Minor Changes

  • #237 51e383d Thanks @rezrah! - Added Grid-specific design tokens.

    --grid-spacing-margin
    --grid-spacing-row
    --grid-spacing-column-gap

@primer/react-brand@0.17.0

Minor Changes

Patch Changes

  • #243 9c479f9 Thanks @josepmartins! - Added support for [Octicons](https://primer.style/design/foundations/icons) in the Card component. The new Card.Icon child is optional, and can be used alongside a Card.Label. Icon color and background can be customized using the color and hasBackground prop respectively.

    <Card href="https://github.com">
      <Card.Icon icon={CopilotIcon} color="purple" hasBackground />
      <Card.Heading>Code search & code view</Card.Heading>
      <Card.Description>
        Enables you to rapidly search, navigate, and understand code, right from GitHub.com.
      </Card.Description>
    </Card>
  • #246 e66ffe0 Thanks @TylerJDev! - Fixes zoom issue in SubdomainNavBar where secondary CTA link would disappear at 200% zoom, or specified width

  • #237 51e383d Thanks @rezrah! - Improved type defintion accuracy for SubdomainNavBar.PrimaryAction by forwarding all default props from HTMLAnchorElement. This will prevent compiler errors on attributes like onClick.

  • #240 6d590e2 Thanks @danielguillan! - Added a size prop to control Testimonial's text size

  • #245 52cc40d Thanks @TylerJDev! - Fixes focus navigation within mobile menu in SubdomainNavbar

@primer/brand-storybook@0.17.0

@primer/brand-e2e@0.17.0

@primer/brand-fonts@0.17.0

@primer/brand-config@0.17.0

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@primer-css primer-css temporarily deployed to github-pages April 20, 2023 21:26 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 24, 2023 14:46 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 25, 2023 13:08 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 25, 2023 13:38 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 25, 2023 14:50 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 25, 2023 17:44 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 26, 2023 06:34 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 26, 2023 13:24 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages April 26, 2023 13:37 — with GitHub Actions Inactive
@rezrah
Copy link
Collaborator

rezrah commented Apr 26, 2023

Release testing notes:

Large testimonial variant

✅ working as expected

Screenshot 2023-04-26 at 14 52 47

Grid

✅ working as expected

Screenshot 2023-04-26 at 14 54 46

Image

❌ not working as expected

Typescript error when using srcSet. Compiler suggesting that as prop is required, when it shouldn't be.

Screenshot 2023-04-26 at 14 44 20

Card.Icon

❌ not working as expected

Typescript error in Card.Icon when passing a reference to an Octicon function, as described in the docs. Error disappears when passing the Octicon as a ReactElement.

icon={<RocketIcon />} works
icon={RocketIcon} doesn't work

Quick fix to unblock the release is to update the documentation examples to use the former.

We should in the long-term however, fix the underlying error, as the latter is the recommended happy path.

Screenshot 2023-04-26 at 14 41 03

Screenshot 2023-04-26 at 15 08 37

@josepmartins josepmartins mentioned this pull request Apr 26, 2023
9 tasks
@JoshBowdenConcepts JoshBowdenConcepts mentioned this pull request Apr 26, 2023
9 tasks
@primer-css primer-css temporarily deployed to github-pages April 26, 2023 16:05 — with GitHub Actions Inactive
@rezrah
Copy link
Collaborator

rezrah commented Apr 27, 2023

Testing update: Issues have been resolved and verified during second round of testing.

Release good to go 🚀

@rezrah rezrah merged commit 3f8e560 into main Apr 27, 2023
@rezrah rezrah deleted the changeset-release/main branch April 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants