Add Card.Icon

[josepmartins]

Summary

Add Card.Icon to the Card component. This allows using Octicons in the Card component to fit future and existing use cases.

Icon

Icon + Label

List of notable changes:

• added Icon as part of the composable API
• added a shared color constants to retrofit Card and Label usage.
• updated Card layout to use grid-template-areas for the Icon + Label combination
• updated Card documentation
• added new stories and tests coverage

What should reviewers focus on?

• Storybook: https://primer-e75d38a33c-26139705.drafts.github.io/storybook/?path=/story/components-card-features--icon
• Documentation: https://primer-e75d38a33c-26139705.drafts.github.io/components/Card#icon

Steps to test:

Supporting resources (related issues, external links, etc):

• Card Icon and Image API explorations: https://www.figma.com/file/zC7Ox3GyswledNqWVltyzY/Primer-Brand---Card-API?node-id=204-1436&t=9uWQueYUx8tOJ8Od-4

Contributor checklist:

• All new and existing CI checks pass
• Tests prove that the feature works and covers both happy and unhappy paths
• Any drop in coverage, breaking changes or regressions have been documented above
• New visual snapshots have been generated / updated for any UI changes
• All developer debugging and non-functional logging has been removed
• Related issues have been referenced in the PR description

Reviewer checklist:

• Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• Check that tests prove the feature works and covers both happy and unhappy paths
• Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

[changeset-bot]

🦋 Changeset detected

Latest commit: 84cb913

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@primer/react-brand	Patch
@primer/brand-primitives	Patch
@primer/brand-e2e	Patch
@primer/brand-fonts	Patch
@primer/brand-config	Patch
@primer/brand-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🔍 Design token changes found

View CSS variable changes

- --brand-Label-color-default: var(--base-color-scale-blue-5);
+ --brand-Label-color-default: var(--brand-color-text-default);

- --brand-Label-color-default: var(--base-color-scale-blue-4);
+ --brand-Label-color-default: var(--brand-color-text-default);

- --brand-Label-color-default: var(--base-color-scale-blue-5);
+ --brand-Label-color-default: var(--brand-color-text-default);

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

[danielguillan]

Looking good!

[rezrah]

Should this be 24x24?

[rezrah]

This looks great @josepmartins. Left some 💬 but also pre-emptively approving.

One additional comment: Can we add a playground to Storybook now? With the color variations to Card.Icon and Card.Label, I think it would be helpful to users if they can toggle and preview the colors in Storybook.

Also FYI that your snapshots are out-of-date.

[josepmartins]

@rezrah thank you!

I've added a basic Playground for icon and label colors, happy to iterate on upcoming PR's if needed: https://primer-e75d38a33c-26139705.drafts.github.io/storybook/?path=/story/components-card--playground

@egim I've introduced some changes on the Card inner layout and tested using the Stack component, it should work fine out of the box even when Cards have different content or line lenght. Let me know if you have questions.

Stacked example: https://primer-e75d38a33c-26139705.drafts.github.io/storybook/?path=/story/components-card-features--stacked

[egim]

@egim I've introduced some changes on the Card inner layout and tested using the Stack component, it should work fine out of the box even when Cards have different content or line lenght. Let me know if you have questions.

This is wonderful, we will utilize very soon. Thank you @josepmartins! ❤️