Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviate publish status messages? #518

Closed
shawnbot opened this issue Jun 29, 2018 · 3 comments · Fixed by #498
Closed

Abbreviate publish status messages? #518

shawnbot opened this issue Jun 29, 2018 · 3 comments · Fixed by #498

Comments

@shawnbot
Copy link
Contributor

The new per-package publish statuses on PRs in #157 are friggin' rad, @jonrohan. I wonder if we could abbreviate them so that the longer ones aren't truncated:

image

Maybe we just nix the package name from the message so that it reads:

npm publish stylelint-config-primer @2.3.0-alpha.7d60d746

It'd be ideal of the package name and @{version} bit could be together, but I think the context (bold part?) has to be unique in order for them all to be displayed.

@jonrohan
Copy link
Member

jonrohan commented Jun 29, 2018

It'd be ideal of the package name and @{version} bit could be together, but I think the context (bold part?) has to be unique in order for them all to be displayed.

true, they'll roll up if the bold part isn't unique. We could cut it down all the way to this:

stylelint-config-primer @2.3.0-alpha.7d60d746

Maybe the body part isn't even necessary, then we could have it all in the bold

stylelint-config-primer@2.3.0-alpha.7d60d746

@shawnbot
Copy link
Contributor Author

Just thinking through to how this would affect the Octicons monorepo... Could we distinguish npm and Gem publish actions? IIRC we can't use emoji in those (otherwise I'd suggest 📦 and 💎), but maybe:

  • jekyll-octicons@7.4.0-alpha.7d60d746 on RubyGems
  • octicons@7.4.0-alpha.7d60d746 on npm
  • octicons@7.4.0-alpha.7d60d746 on RubyGems
  • @github/octicons-react@7.4.0-alpha.7d60d746 on npm

Also realizing that having the same package name on npm and RubyGems would prevent both from showing up. ☹️

shawnbot added a commit that referenced this issue Jan 24, 2019
@jonrohan jonrohan mentioned this issue Jan 24, 2019
22 tasks
@shawnbot
Copy link
Contributor Author

@jonrohan I addressed this in 80c32bd for #498, which makes the checks look like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants