Add background-color: #fff to .avatar-child
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommendation from a support request; should ensure any child avatar in the pairing is visible even with a transparent background.
mdo
added a commit
that referenced
this pull request
Jul 9, 2015
Add `background-color: #fff` to `.avatar-child`
|
Why not on |
|
@jonrohan I didn't want to unnecessarily style all avatars given most of them appear on white anyway. If we need to later, I'm down to redo this and extend it to more avatars. |
timv88
pushed a commit
to timv88/primer
that referenced
this pull request
Aug 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendation from a support request; should ensure any child avatar in the pairing is visible even with a transparent background.