Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SF Mono font in Firefox and Safari (take 2) #1451

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jun 8, 2021

This is another attempt after reverting #992 (comment).

I paired with @nickcanz (thanks 🙇 ) and we found the following:

  • This stackoverflow is correct and an older version of SF Mono causes the "bold" problem. Updating to a new version fixed it.
  • For users that still have the old version installed, having SFMono-Regular declared before SF Mono also fixes the problem.

With that we have the following stack:

$mono-font:
  ui-monospace, // support for Safari
  SFMono-Regular, // support for Chrome with an older version of SF Mono
  SF Mono, // support for Firefox
  Consolas, Liberation Mono, Menlo, monospace !default;

Also removed the " since it gets stripped anyways when compiling the SCSS.

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2021

🦋 Changeset detected

Latest commit: 91f18ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai requested a review from jonrohan June 8, 2021 09:12
@simurai simurai marked this pull request as ready for review June 8, 2021 09:12
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a second chance, we should be ready with a patch release if we need to revert this quickly.

@simurai simurai merged commit 9181b47 into main Jun 9, 2021
@simurai simurai deleted the mono-font-stack branch June 9, 2021 01:28
@primer-css primer-css mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants