Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling changes for button.ellipsis-expander #175

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Conversation

muan
Copy link
Contributor

@muan muan commented Feb 17, 2016

I think this belongs here. 😬

Before

ugly buttons

After

not buttons

The bottom padding is more of a hack for buttons and its oddness with line-height, but it doesn't change how a.ellipsis-expander looks. ✌️

@mdo mdo added the css label Feb 17, 2016
@mdo
Copy link
Contributor

mdo commented Feb 17, 2016

Sounds good to me!

Have you done the release process for Primer to tackle this yourself or would you like me to push it out?

muan added a commit that referenced this pull request Feb 19, 2016
Styling changes for button.ellipsis-expander
@muan muan merged commit cd6e2ad into master Feb 19, 2016
@muan muan deleted the button-expander branch February 19, 2016 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants