Remove trailing margin from HTML elements within markdown tables #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed84ede The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jackbrewer
had a problem deploying
to
github-pages
GitHub Actions
Failure
simurai
reviewed
Jan 18, 2023
src/markdown/markdown-body.scss
Outdated
| @@ -78,6 +78,12 @@ | |||
| border: 0; | |||
| } | |||
|
|
|||
| td { | |||
There was a problem hiding this comment.
Should we move this into markdown/tables.scss? Since it's a specific override for tables.
There was a problem hiding this comment.
Ah, I missed that file! Yep, that makes sense – styles have been moved.
jackbrewer
had a problem deploying
to
github-pages
GitHub Actions
Failure
simurai
had a problem deploying
to
github-pages
GitHub Actions
Failure
simurai
approved these changes
Jan 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Hi 👋 , I have a pretty niche styling problem which happens when using an HTML element within a table cell within a
.markdown-bodyclass. The existing.markdown-bodystyles add a trailing margin to various elements. When inside a table cell, this margin causes misalignment and makes the cell stand out from other text-only cells.For my specific use-case, I'm using a
<details>element within a table when adding comments to GitHub pull requests.Before
After
What approach did you choose and why?
I followed the example set by the existing
.markdown-body blockquote > :last-childselector, adding a child combinator to remove themargin-bottom. This means it will apply to any direct child element for consistency.What should reviewers focus on?
I'm new here so have no concept of the scope of this change! I'm not using Primer directly, just as part of the GitHub UI.
Can these changes ship as is?