Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove primer-page-sections #438

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Remove primer-page-sections #438

merged 4 commits into from
Oct 17, 2018

Conversation

sophshep
Copy link

@sophshep sophshep commented Jan 18, 2018

This PR removes the primer-page-sections package from Primer, since the new big spacers mean it's no longer needed.

Corresponding GitHub PR that removes the dependency on these styles: https://github.com/github/github/pull/84018
cc/ @primer/ds-core

@jonrohan
Copy link
Member

Update your branch with latest dev to get rid of those failures

@jonrohan jonrohan mentioned this pull request Jun 14, 2018
22 tasks
@jonrohan jonrohan changed the base branch from dev to master June 25, 2018 19:40
@shawnbot shawnbot changed the base branch from master to release-11.0.0 October 16, 2018 20:56
@shawnbot
Copy link
Contributor

Okay, I rebased this with the #498 v11 release branch. Assuming tests pass, I'll merge it into that PR. 🤞

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants