Fix Storybook #489
Merged
Fix Storybook #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrohan
reviewed
May 11, 2018
| @@ -1,7 +1,6 @@ | |||
| .DS_Store | |||
| .sass-cache | |||
| node_modules | |||
| **/package-lock.json | |||
There was a problem hiding this comment.
Should we direct that at modules/ folders?
There was a problem hiding this comment.
Damn. I wonder why those weren't generated on my end. Mind checking them in on this branch?
There was a problem hiding this comment.
It didn't create them for me.
There was a problem hiding this comment.
Okay, I went and ran:
lerna exec -- npm iThen bootstrapped again just to be sure, and they're all in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do a couple of things to fix Storybook on the
devbranch:Add an
.nvmrcso that we can all more easily use Node >=8 (and npm@5)Add an
.npmrcso that anything wenpm installwill be saved using the exact version.Update all of the Storybook dependencies to
3.4.3with:npm i @storybook/{react,addons,addon-options}Remove
**/package-lock.jsonfrom.gitignoreand add the lockfiles to git, hopefully to avoid issues like these in the future.The root of the problem appears to have been that it was easy to end up with different versions of Storybook and its "addon" dependencies installed as we switch from branch to branch. This is what I think would lead Storybook to find that its peer dependencies (such as
babel-core) weren't installed.