-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Marketing Buttons #613
Conversation
d8e7b13
to
2598e4c
Compare
f874069
to
76bf5e5
Compare
76bf5e5
to
43a6b2f
Compare
i updated i tried running Stories locally but got an error that |
@gladwearefriends you should be able to run storybook now. You can see what it looks like on the site at this branch deployment: https://primer-css-marketing-buttons-2018.now.sh/css/components/marketing-buttons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, here's the output of < .btn-orange
< .btn-outline-green
< .btn-outline-orange
< .btn-outline-purple
< .btn-transparent
> .btn-large-mktg
> .btn-mktg
> .btn-outline-mktg
> .btn-primary-mktg |
This updates the marketing buttons module based on the new github site design changes.
Similarly to the new type styles #583, all marketing buttons are also suffixed with
-mktg
This PR removes all old button styles for the following new ones:
btn-mktg
: a solid blue buttonbtn-primary-mktg
: a solid green button (used sparingly and for extra emphasis, hence "primary")btn-outline-mktg
: an outlined blue buttonbtn-large-mktg
: extends the button to a larger sizeIt also:
primer-marketing-support
that the new buttons need,blue-450
andgreen-450
let me know if i missed anything, and if the docs could be better worded :)
@sophshep
/cc @primer/ds-core @trosage @skullface