Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Marketing Buttons #613

Merged
merged 9 commits into from
Jan 25, 2019
Merged

Conversation

gladwearefriends
Copy link
Contributor

@gladwearefriends gladwearefriends commented Nov 27, 2018

This updates the marketing buttons module based on the new github site design changes.
Similarly to the new type styles #583, all marketing buttons are also suffixed with -mktg

This PR removes all old button styles for the following new ones:

  • btn-mktg: a solid blue button
  • btn-primary-mktg: a solid green button (used sparingly and for extra emphasis, hence "primary")
  • btn-outline-mktg: an outlined blue button
  • btn-large-mktg: extends the button to a larger size

It also:

  • adds 2 new color variables to primer-marketing-support that the new buttons need, blue-450 and green-450

let me know if i missed anything, and if the docs could be better worded :)

@sophshep
/cc @primer/ds-core @trosage @skullface

@gladwearefriends gladwearefriends requested review from sophshep and a team and removed request for a team November 27, 2018 20:25
@gladwearefriends gladwearefriends changed the title [WIP] Updates to Marketing Buttons Updates to Marketing Buttons Nov 30, 2018
@gladwearefriends
Copy link
Contributor Author

i updated stories.js! @shawnbot i think i misunderstood what you were saying originally in your comment 😅

i tried running Stories locally but got an error that $blue-450 is undefined. I want primer-marketing-buttons to get that from primer-marketing-support (added those vars in this PR too). is there something im missing? let me know if hopping on a slack/zoom chat would be easier to debug. i appreciate you reviewing these PRs immensely!

@shawnbot
Copy link
Contributor

@gladwearefriends you should be able to run storybook now. You can see what it looks like on the site at this branch deployment:

https://primer-css-marketing-buttons-2018.now.sh/css/components/marketing-buttons

@shawnbot shawnbot changed the base branch from master to release-11.0.0 January 24, 2019 00:43
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Since this is a breaking change, I'd like to queue it up for #498 unless @sophshep (or anyone else) has any objections.

@jonrohan jonrohan mentioned this pull request Jan 24, 2019
22 tasks
@shawnbot shawnbot merged commit 24b4159 into release-11.0.0 Jan 25, 2019
@shawnbot shawnbot deleted the marketing-buttons-2018 branch January 25, 2019 19:56
@shawnbot
Copy link
Contributor

For posterity, here's the output of script/selector-diff-report | egrep ' .btn-[-a-z]+ ?$' | sort, which tells us which button classes were removed and added:

< .btn-orange
< .btn-outline-green
< .btn-outline-orange
< .btn-outline-purple
< .btn-transparent
> .btn-large-mktg
> .btn-mktg
> .btn-outline-mktg
> .btn-primary-mktg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants