-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs release fixes #631
Merged
Merged
Docs release fixes #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
force-pushed
the
docs-release-fixes
branch
from
January 4, 2019 18:35
989e91b
to
b43e24d
Compare
shawnbot
force-pushed
the
docs-release-fixes
branch
from
January 4, 2019 18:40
b43e24d
to
f3539dc
Compare
shawnbot
commented
Jan 4, 2019
FYI @jonrohan, the actual diff is way easier to read. I merged #632 into this branch manually, which is (I think) why those commits are showing up. |
jonrohan
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scanning over this looks good. FWIW I'm fine with loosing rc
release naming. It shouldn't effect how we release.
This was referenced Dec 27, 2022
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested these commits on #625 directly, but for the sake of tracking my work better I force-pushed that release branch back to 7ec1057 and am going to merge this separately. Here's the deal:
Docs site deployment and all release scripts are now run in the Travis
deploy
stage, which makes them easier to track. They will only ever run in the "push" build (not the "pull request" build; /cc Eliminate Travis PR builds #259), and all pre-deployment now logic lives inbefore_deploy
rather thanafter_success
.script/after_success
is gone.Replace our whole crazy release candidate logic with a
lerna publish --canary
, which allows Lerna to do the heavy lifting again.primer@10.10.3-rc.0
, but instead something likeprimer@10.10.4-alpha.<sha>
(note the patch version increment!). I liked being able to just remove the-rc.x
bit from the end when updating dependents, but there's a serious issue of code rot in that custom release candidate logic, and this will all be going away if/when we move away from the monorepo and conventional commits anyway.I had to add a kind of silly workaround to deal with how Lerna undoes its changes to
version
field changes inpackage.json
files after a canary release. Theprimer/scripts/postinstall.js
Node script is a Lerna-specific hook that just writes the published version to../VERSION
, andscript/deploy-docs
then updates itsprimer
dependency version to this value so that Now will pull the correct version of Primer when it deploys. (Without this, Now deployments fail in a release because theprimer
dependency version hasn't yet been published.)Fix the docs deployment URL branch slug, which used to be
$TRAVIS_BRANCH
but should be$TRAVIS_PULL_REQUEST_BRANCH
. Before this, Release 10.10.3 #625 attempts to alias toprimer-css-master
: