Release 13.0.0 #887
Release 13.0.0 #887
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-release-1300.primer.now.sh |
BREAKING CHANGE: the build directory is no longer included in the
distributed package. build/stats.json can be found at
dist/stats/primer.json, and `require('@primer/css/build')` references
should be rewritten to `require('@primer/css/dist/primer')`.
Reorganize and lint scripts; remove unused dev dependencies
BREAKING CHANGE: .text-pending is officially deprecated BREAKING CHANGE: .bg-pending is officially deprecated
There was a problem hiding this comment.
👍 this PR looks good me.
For the draft PR on dotcom https://github.com/github/github/pull/123801, I think the only thing left is remove all the .container classes. But it seems there are a lot still in use. 😳 Might take a while until everything is refactored? Also because it gets overridden in stylesheets.
I guess we don't have to rush this release and there can be more patch and minor releases that go first. I'll mark this as "Request changes" until https://github.com/github/github/pull/123801 is ready.
Upgrade to stylelint-config-primer@8.0.0
Select Menu improvements
There was a problem hiding this comment.
Ok, by adding the .container styles to dotcom https://github.com/github/github/pull/123969, this should be ready to go. 👍 🚢 💨
Upgrade Doctocat + update LivePreviewWrapper
Primer CSS Major Release
Version: 📦 13.0.0
Approximate release date: 📆 September 16, 2019
💥 Breaking Change
.container,.columns,.column, and related classes Removing deprecated column grid styles #662.btn-purpleAdios purple buttons #736 👋 💜.text-pendingand.bg-pendingDelete .text-pending and .bg-pending #888.dropdown-menu-contentRemove .dropdown-menu-content #884💅 Polish
📝 Documentation
/css/objects/layoutshould404redirect on this deployment. Redirect /objects/layout -> /objects/grid #896🏠 Internal
Ship checklist
CHANGELOG.mdversionfield inpackage.jsongithub/githubgithub/githubFor more details, see RELEASING.md.
/cc @primer/ds-core