Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer 12.5.0 #832

Merged
merged 172 commits into from
Jul 23, 2019
Merged

Primer 12.5.0 #832

merged 172 commits into from
Jul 23, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 2, 2019

Primer CSS Minor Release

Version: 📦 12.5.0
Approximate release date: 📆 TBD (sometime after 2019-07-15)

🚀 Enhancement

🐛 Bug Fix

📝 Documentation


Ship checklist

For more details, see RELEASING.md.

/cc @primer/ds-core

BEM multi-word convention for Element or Modifier classes
@vercel vercel bot temporarily deployed to staging July 17, 2019 23:29 Inactive
simurai and others added 7 commits July 22, 2019 11:37
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
While this fixes the backtick-on-backtick problem by using a zero-width space, it's still confusing to see `erb` in the source code while referencing `html` in the copy.
Fix markdown typos in Contributing docs page
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this my preemptive approval 😁

@simurai simurai marked this pull request as ready for review July 23, 2019 05:01
@shawnbot shawnbot merged commit 371213f into master Jul 23, 2019
@shawnbot shawnbot deleted the release-12.5.0 branch August 7, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants