-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primer 12.5.0 #832
Merged
Merged
Primer 12.5.0 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEM multi-word convention for Element or Modifier classes
Color system docs updates
Toast component
Color utility table tweaks
Select Menu component
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
While this fixes the backtick-on-backtick problem by using a zero-width space, it's still confusing to see `erb` in the source code while referencing `html` in the copy.
Fix markdown typos in Contributing docs page
Side Nav component
shawnbot
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this my preemptive approval 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primer CSS Minor Release
Version: 📦 12.5.0
Approximate release date: 📆 TBD (sometime after 2019-07-15)
🚀 Enhancement
.Toast
component Toast component #831.SideNav
component Side Nav component #827.SelectMenu
component Select Menu component #808font-display: swap
to@font-face
declarations Prefer FOUT over FOIT with custom @font-face marketing font #780flex-grow-0
,flex-order-[1,2,none]
andwidth-auto
utilities Adding flex utilities for grow, order, and width #763$marketing-font-path
to/fonts/
Fix directory path for font files #837🐛 Bug Fix
📝 Documentation
Ship checklist
version
field inpackage.json
CHANGELOG.md
github/github
https://github.com/github/github/pull/119544github/github
For more details, see RELEASING.md.
/cc @primer/ds-core