Remove non-ascii characters from scss files #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-fork-shreve-master.primer.now.sh |
This was referenced Dec 18, 2022
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace em dashes with hyphens so these files are ascii characters only. These files have been producing an error in my jekyll site way downstream.
I traced the issue to the jekyll-primer-theme gem, and was told there that I should make this fix upstream, here.
This can be fixed by setting
LANG=en_US.UTF-8in the terminal environment, but removing this unnecessary utf8 will more widely fix the problem./cc @primer/ds-core