Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/setup-node: "version" -> "node-version" #947

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

shawnbot
Copy link
Contributor

I noticed a check annotation today warning us about the version option in actions/setup-node being deprecated in favor of node-version. This changes it from the former to the latter.

@vercel
Copy link

vercel bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/dq231ccvp
🌍 Preview: https://primer-css-git-actions-node-version.primer.now.sh

@shawnbot shawnbot requested a review from a team October 15, 2019 16:48
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢👍

@shawnbot shawnbot merged commit 03f5ac4 into master Oct 16, 2019
@shawnbot shawnbot deleted the actions-node-version branch October 16, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants