No F&*#$ing way: Remove expletives from primer #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ You can find them in two sizes: the default `.btn` and the smaller `.btn-sm`. | |||
|
|
|||
| ## Primary | |||
|
|
|||
| Primary buttons are green and are used to indicate the *primary* action on a page. When you need your shit to stand out, rock the `.btn.btn-primary`. You can use it on both button sizes—just add `.btn-primary`. | |||
| Primary buttons are green and are used to indicate the *primary* action on a page. When you need your the buttons stand out, use the `.btn.btn-primary`. You can use it with both button sizes—just add `.btn-primary`. | |||
There was a problem hiding this comment.
Nice change! 🎉
Though, I think "your buttons" reads better than "your the buttons;" unless you intended "you are the buttons."
There was a problem hiding this comment.
Nice catch definitely meant "your buttons"
|
Thanks @jonrohan! Now I won't mind using Primer as a teaching tool. Those were the only expletives I saw. I commented with just one minor suggestion on grammar/readability. 😄 |
jonrohan
added a commit
that referenced
this pull request
Apr 5, 2015
No F&*#$ing way: Remove expletives from primer
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #95
Updating our language to be more friendly. @zackdouglas these were the only places I could find some references, did you see any others?
cc @mdo