started work on icons section #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
migrate-octicons
branch
2 times, most recently
from
0e86dde to
258be60
Compare
lukasoppermann
force-pushed
the
migrate-octicons
branch
3 times, most recently
from
ad8a698 to
b67d755
Compare
…e pdf download work
lukasoppermann
force-pushed
the
migrate-octicons
branch
2 times, most recently
from
3f10d65 to
e463729
Compare
lukasoppermann
force-pushed
the
migrate-octicons
branch
from
e463729 to
c653921
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
emilybrick
reviewed
Feb 7, 2023
emilybrick
reviewed
Feb 7, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Thanks for doing this, @lukasoppermann! 💖
I made a few adjustments:
- Updated the site to fetch the Octicon data from
unpkg.comso we can get the latest data every time we build. This means that our documentation doesn't rely on the@primer/octiconsversion innode_modulesbeing up-to-date. - Removed the hero and made a couple of styling updates.
- Renamed "Icon overview" to "Overview" in the nav. "Icon overview" felt redundant nested under the "Icons" item.
colebemis
approved these changes
Feb 7, 2023
emilybrick
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once completed this fixes https://github.com/github/primer/issues/1630.
Related
Redirects
The following redirects are needed once this PR gets merged
Todo
build:iconsneeds to be run on build of docs@primer/octicons-reactcan be usedProblems
blob-streamthrows errors in the individual icon pages (will try to replace with native stream)jsPDFcreates an error when gatsby is built