Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Octicon SVGs for same icon/options combination #491

Merged
merged 3 commits into from
Sep 2, 2020

Commits on Aug 27, 2020

  1. Cache Octicon SVGs for same icon/options combination

    This PR upstreams an optimization we've been using
    internally to speed up rendering the same octicon
    multiple times.
    
    Rendering octicons can be expensive when done often on a page. For
    example, rendering the same "check" octicon in a large list of items can
    add up on a page, so often we'll render it once and then pass in the
    rendered HTML string into the list items.
    
    Co-authored-by: Simon Taranto <srt32@github.com>
    joelhawksley and srt32 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    1c413ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ba70ec View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    7a0eaf9 View commit details
    Browse the repository at this point in the history