Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The release build doesn't include the dist directory #110

Closed
shawnbot opened this issue Jul 9, 2018 · 0 comments · Fixed by #111
Closed

The release build doesn't include the dist directory #110

shawnbot opened this issue Jul 9, 2018 · 0 comments · Fixed by #111
Assignees
@shawnbot
Labels
bug Something isn't working ⭐️rep an industry leading reputation

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Jul 9, 2018

You can't import the latest version of primer-react because the published package doesn't include the dist/ directory. This is because I put the build step in our preversion run-script instead of prepublishOnly, and since we're not versioning on Travis it never ran. So yeah, I need to fix that. 🤦‍♂️
@shawnbot shawnbot added bug Something isn't working ⭐️rep an industry leading reputation labels Jul 9, 2018
@shawnbot shawnbot self-assigned this Jul 9, 2018
This was referenced Jul 9, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnbot shawnbot

Labels
bug Something isn't working ⭐️rep an industry leading reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch release v0.0.8-beta primer/react
1 participant
@shawnbot