Skip to content

Button bug fixes and visual updates #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Button bug fixes and visual updates #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bff3840
add icon control
langermank Sep 26, 2022
d10bc76
alignment CSS and props
langermank Sep 27, 2022
892f013
more cleanup
langermank Sep 29, 2022
5bb931a
move stories to features
langermank Sep 29, 2022
b553e93
make counter part of button
langermank Oct 6, 2022
9f097e1
fix export
langermank Oct 6, 2022
951467b
cleanup stories
langermank Oct 6, 2022
da4960e
cleanup size CSS
langermank Oct 7, 2022
c02b9f2
cleanup CSS
langermank Oct 7, 2022
ef75c95
Merge branch 'main' of https://github.com/primer/react into button-bl…
langermank Oct 7, 2022
f30ded9
rename visual props
langermank Oct 7, 2022
9e1eda9
Create mean-parrots-burn.md
langermank Oct 7, 2022
4ee2788
tests
langermank Oct 7, 2022
1fb6eec
Merge branch 'button-block-alignment' of https://github.com/primer/re…
langermank Oct 7, 2022
f9e76d7
snaps
langermank Oct 7, 2022
b20488b
Merge branch 'main' into button-block-alignment
langermank Oct 7, 2022
5b000b3
Merge branch 'main' of https://github.com/primer/react into button-bl…
langermank Dec 5, 2022
79f8967
address feedback
langermank Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/mean-parrots-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
"@primer/react": major
---


- Add a block prop for full width
- Add alignContent prop to align content to center or start
- Use control sizing CSS variables
- Use height over padding for more control over sizing
- Refactor Button.Counter to better align with the other visual props
- Rename visual props to better align with other Primer components
- Deprecate outline variant

Loading