Revert "Button alignment and size bug fixes (#2652)" #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e5f1c9.
🦋 Changeset detectedLatest commit: 723b77c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
requested review from
a team,
joshblack,
mattcosta7 and
langermank
langermank
approved these changes
Jan 10, 2023
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mattcosta7
approved these changes
Jan 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1e5f1c9.
Unfortunately we had to roll back the commit that includes changes for
Buttonstyling enhancement due to introducing major styling changes*.*With the new enhancements, the way that consumers override the default styling of
Buttoncomponent viasxprop has changed. Please see the relevant links below for more info.Memex integration test PR : https://github.com/github/memex/pull/14174#issuecomment-1376198318
Slack thread: https://github.slack.com/archives/C02NUUQ9C30/p1673294619441499
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.