Button alignment and size bug fixes #2652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: caf0f23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
langermank
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
added
the
update snapshots
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-actions
bot
removed
the
update snapshots
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
broccolinisoup
added a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit 1e5f1c9.
broccolinisoup
added a commit
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: These are the non breaking changes from this PR
Improvements
blockprop for full widthalignContentprop to align content to center or startcontrolsizing CSS variable values (not using CSS vars just yet)heightover padding for more control over sizingVisual updates
Addresses a few things missing from this discussion: https://github.com/github/primer/discussions/1016
invisiblehover states (will update these colors when new functional colors are addressed)Closes:
Screenshots
Please refer to the comprehensive Storybook stories- this is just a small sample of some of the changes
invisiblebuttons use default text color if visuals are present, and accent blue if no visuals.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.