Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes transparent bg PointerBox and adds stories #3094

Merged
merged 11 commits into from
Apr 3, 2023

Conversation

mperrotti
Copy link
Contributor

  • Fixes the issue where there is a visible border between the box and the caret when the PointerBox's background color is partially transparent.
  • Adds PointerBox to Storybook

Closes #1542

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and broccolinisoup March 30, 2023 14:40
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

🦋 Changeset detected

Latest commit: 5899b0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.18 KB (+0.14% 🔺)
dist/browser.umd.js 95.75 KB (+0.16% 🔺)

@mperrotti mperrotti temporarily deployed to github-pages March 30, 2023 16:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3094 March 30, 2023 16:28 Inactive
@mperrotti mperrotti temporarily deployed to github-pages March 31, 2023 14:58 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3094 March 31, 2023 14:58 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you solved this ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PointerBox is being drawn incorrectly in all dark themes.
2 participants